semantic-conventions
semantic-conventions copied to clipboard
open-telemetry
Extends GraphQL Spans
Fixes #
Changes
This pull requests extends the capabilities of graphql open telemetry.
It adds a span for the execution of a GraphQL operation and a span for the resolvers.
I left a few comments in the definition to open a dicussion about the changes.
Merge requirement checklist
- [ ] CONTRIBUTING.md guidelines followed.
- [ ] CHANGELOG.md updated for non-trivial changes.
- [ ] schema-next.yaml updated with changes to existing conventions.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: PascalSenn (481e41443a29c2c4fcb7c8fc1dba6b4c5fb552f8, 2d61ae4fa6022af24aa97f2f293686ad2d512202, 9a72c985c592bdd179fa29a50fd7f075bef9a52c, 19d80b7ee4bde9a7480177116180d2f8da31e425, eade875e7df8e28364b19a4e08bbe97eef65f5fe, 43518fcae9497d8134cccb3a4cac707b8784d420, 186ea98813fcf737e24f6c27f187bc1a2e09c249)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was marked stale due to lack of activity. It will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closed as inactive. Feel free to reopen if this PR is still being worked on.
@jsuereth Can this Pull Request be reopened? How can i get feedback for this?
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Hi @PascalSenn,
Sorry for not reviewing the PR for a long time - unfortunately we don't have any GraphQL experts among semantic conventions approvers.
We have some folks who contributed https://github.com/open-telemetry/semantic-conventions/pull/1389 recently and I wonder if they could give this one a review as well.
@kaylareopelle @robertlaurin would you mind taking a look and sharing ant feedback?
Thanks!
PS: happy to review from general semconv perspective sometime next week.
FYI: There is renewed effort in the GraphQL Community in pushing this over the finish line: https://github.com/graphql/graphql-wg/discussions/1691