semantic-conventions icon indicating copy to clipboard operation
semantic-conventions copied to clipboard

[chore] Additional test case cases for SQL sanitisation and summary

Open stevejgordon opened this issue 1 month ago • 2 comments

Changes

Adds extra test cases for SQL query text sanitisation and summary parsing to cover more scenarios.

We have used these test cases in the .NET implementation while refining and optimising it.

An open area for discussion is whether it should be optional to skip numeric literal sanitisation when the value is used as part of a TOP (e.g. SELECT TOP (10) FROM MyTable) statement or type declaration (e.g. ALTER TABLE Orders ADD COLUMN OrderStatus NVARCHAR(50)). The tests currently allow this as an optional expectation.

cc @alanwest

Merge requirement checklist

  • [x] CONTRIBUTING.md guidelines followed.
  • [ ] ~Change log entry added, according to the guidelines in When to add a changelog entry.~
    • If your PR does not need a change log, start the PR title with [chore]
  • [ ] ~Links to the prototypes or existing instrumentations (when adding or changing conventions)~

stevejgordon avatar Oct 22 '25 06:10 stevejgordon