semantic-conventions
semantic-conventions copied to clipboard
Add Browser UserAction Event
Fixes #
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
- [ ] CONTRIBUTING.md guidelines followed.
- [ ] Change log entry added, according to the guidelines in When to add a changelog entry.
- If your PR does not need a change log, start the PR title with
[chore]
- If your PR does not need a change log, start the PR title with
- [ ] schema-next.yaml updated with changes to existing conventions.
blocking temporarily to discuss whether we can unify screen coordinate representation with #2070
See #2145
This PR was marked stale due to lack of activity. It will be closed in 7 days.
What's the status of this PR, is this ready for the general SemConv review?
Since @Karlie-777 is not actively working on this I am continuing her work here https://github.com/open-telemetry/semantic-conventions/pull/2992 (I couldn't push to the same branch unfortunately). I am already working on the instrumentation side and we want to keep things moving
@thompson-tomo Could you take another look there? For starters I moved all the body fields to attributes, could you replicate any other comments you have here there so we can continue the conversation?
@david-luna I see you also have a pending comment, I replaced the keyboard.space and keyboard.enter for input as it wasn't very clear to me what was the intention for those either. Input should cover them and the rest of the keys
@MSNev and @breedx-splk You both approved this PR, could you please take another look at the new PR?
Thanks everyone!
Closing this in favor of #2992