semantic-conventions icon indicating copy to clipboard operation
semantic-conventions copied to clipboard

Fix broken docker link

Open ChrsMark opened this issue 1 year ago • 4 comments

Fixes #

Changes

The link https://docs.docker.com/engine/reference/run/#container-identification is outdated. This makes the markdown-link-check to fail.

Spotted at https://github.com/open-telemetry/semantic-conventions/actions/runs/10383411357/job/28748273043?pr=1251.

Merge requirement checklist

ChrsMark avatar Aug 14 '24 07:08 ChrsMark

Hmm, it seems that docker's doc pages are failing here there actually 🤔 .

ChrsMark avatar Aug 14 '24 08:08 ChrsMark

Sometimes websites prevent bots from hitting them. We may want to remove dockerhub as a validated location in the link checker...

jsuereth avatar Aug 14 '24 11:08 jsuereth

I think it'll self-heal - https://github.com/docker/docs/pull/20606

lmolkova avatar Aug 15 '24 00:08 lmolkova

I think it'll self-heal - docker/docs#20606

self-healed!

lmolkova avatar Aug 16 '24 03:08 lmolkova