semantic-conventions icon indicating copy to clipboard operation
semantic-conventions copied to clipboard

Introduce vulnerability component

Open trisch-me opened this issue 1 year ago • 10 comments

Introduce a new security namespace Vulnerability.

Fields are taken from ECS Vulnerability namespace

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

trisch-me avatar Jul 29 '24 12:07 trisch-me

@trisch-me Following up on this PR from this weeks SemConv meeting.

In practice I've noticed that vendors don't always support the convention 1:1. In the OTEL collector we've had to do mappings of attributes for metrics. We currently define a git.repository.cve.count metric. This metric will probably eventually change to vcs.repository.cve.count (or maybe just cve.count with attribute of vcs.repository.url.full). cve.severity is the attribute I'm referring to that doesn't always map. We enum the attribute, but have to remap the value here.

Just wanted to provide this information for additional context. Love seeing these pr's come up.

adrielp avatar Jul 31 '24 18:07 adrielp

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Sep 12 '24 03:09 github-actions[bot]

Hi, is this PR good now? Can we have this merged I'm looking to add vulnerabilities metric.

sachinmalanki avatar Mar 05 '25 14:03 sachinmalanki

@trisch-me, a more generic question to this pull request:

  • Since there are the OCSF standard security findings of vulnerability type, would it make sense to closer align to it?
  • What benefits would this new standard have in addition to the OCSF?
  • Can we state better the expected use cases of this object?

leykin-valeriy avatar Mar 06 '25 12:03 leykin-valeriy

I agree with the comment below: Are there good reasons not to align with the OCSF schema?

@trisch-me, a more generic question to this pull request:

  • Since there are the OCSF standard security findings of vulnerability type, would it make sense to closer align to it?
  • What benefits would this new standard have in addition to the OCSF?
  • Can we state better the expected use cases of this object?

ms-jcorley avatar Mar 19 '25 23:03 ms-jcorley

@leykin-valeriy @ms-jcorley

I am adding this namespace as a part of donation process. We previously discussed the idea of collaborating with OCSF on creating a unified schema about a year ago, but unfortunately, no agreement was reached at that time.

OCSF has a different structure in general, and aligning the two without further discussions on the fields would be challenging. However, if those working on OCSF are interested in adding or updating fields in this namespace to suit their needs, we would be happy to collaborate and explore possible solutions together.

trisch-me avatar Mar 20 '25 12:03 trisch-me

We previously discussed the idea of collaborating with OCSF on creating a unified schema about a year ago, but unfortunately, no agreement was reached at that time.

I'm interested to learn more, especially since OCSF is also under the Linux Foundation now. I've added the topic to Monday's semconv SIG agendra.

trask avatar Apr 09 '25 16:04 trask

I'm interested to learn more, especially since OCSF is also under the Linux Foundation now. I've added the topic to Monday's semconv SIG agendra.

pushing this agenda topic to the April 28 meeting

trask avatar Apr 14 '25 14:04 trask

pushing this agenda topic to the April 28 meeting

pushing (again) to the May 5 meeting

trask avatar Apr 14 '25 15:04 trask

pushing this agenda topic to the April 28 meeting

pushing (again) to the May 5 meeting

Any objections to starting the conversation on the 28th and continuing the conversation on the 5th? The sooner we can at least start having the conversations the sooner we can make progress on these things.

adrielp avatar Apr 14 '25 16:04 adrielp