semantic-conventions icon indicating copy to clipboard operation
semantic-conventions copied to clipboard

Discuss guidance around runner system attributes in distributed tracing

Open adrielp opened this issue 1 year ago • 2 comments

Overview

Discuss and add guidance around setting attributes in traces when multiple runners are tied to a single pipeline.

Note: Removed ...runner.{name, id} from pull request #1075 which can be added back as part of this issue.

Reference:

  • https://github.com/open-telemetry/semantic-conventions/pull/1075#discussion_r1651185234

adrielp avatar Jun 27 '24 22:06 adrielp

@christophe-kamphaus-jemmic

adrielp avatar Jun 27 '24 22:06 adrielp

Since #2013 added resources for workers I think adding a note to the cicd.worker resource would address this issue. It could be something similar to this:

A pipeline run can be executed on several workers. The pipeline run span and its individual child spans (eg. for task runs) of the pipeline run should be associated with the resource for the most appropriate worker. This means that for a pipeline run executing on multiple workers, its task run spans would have different cicd.worker resources.

What do you think?

kamphaus avatar May 02 '25 19:05 kamphaus

@kamphaus - let's add the note & close out this piece of work if possible. Would be nice to have before the start of phase 2 in September.

adrielp avatar Jul 31 '25 13:07 adrielp

I'll prepare a PR...

kamphaus avatar Jul 31 '25 20:07 kamphaus