semantic-conventions icon indicating copy to clipboard operation
semantic-conventions copied to clipboard

Do we need event/logs approver team?

Open lmolkova opened this issue 1 year ago • 5 comments
trafficstars

We don't have a group that would:

  • own/review/approve general logs and events definitions
    • https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/logs.md
    • https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/events.md
  • triage issues in area:event and area:log

lmolkova avatar Jun 21 '24 17:06 lmolkova

Discussed at SemComv WG call on 6/24:

  • events WG focuses on Event spec stability & tooling work to define events
  • event group does not work on logs or specific event definitions
  • we still have general events conventions that this group should be codeowners (triagers/reviewers) for

/cc @MSNev @tedsuo @trask could you please request a group for event owners and add it to https://github.com/open-telemetry/semantic-conventions/blob/b1ad9ae785c3d97cf0c80fe320d9b9156f37e927/.github/CODEOWNERS#L26 ?

lmolkova avatar Jul 08 '24 14:07 lmolkova

requested: https://github.com/open-telemetry/community/issues/2199

trask avatar Jul 09 '24 15:07 trask

this is done now

trask avatar Jul 16 '24 19:07 trask

re-opening, still need to update CODEOWNERS file

trask avatar Jul 16 '24 19:07 trask

Also I realized there's a separate question about logs ownership, so leaving this open

trask avatar Jul 16 '24 19:07 trask

Based on discussions in Logs SIG. Since we merged events and logs into Logs SIG, let's

  • rename open-telemetry/semconv-event-approvers to open-telemetry/semconv-logs-approvers
  • make them codeowners on event and log namespaces in the conventions along with general events and logs docs

/cc @open-telemetry/semconv-event-approvers

lmolkova avatar Feb 05 '25 03:02 lmolkova