semantic-conventions
semantic-conventions copied to clipboard
Do we need event/logs approver team?
We don't have a group that would:
- own/review/approve general logs and events definitions
- https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/logs.md
- https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/events.md
- triage issues in
area:eventandarea:log
Discussed at SemComv WG call on 6/24:
- events WG focuses on Event spec stability & tooling work to define events
- event group does not work on logs or specific event definitions
- we still have general events conventions that this group should be codeowners (triagers/reviewers) for
/cc @MSNev @tedsuo @trask could you please request a group for event owners and add it to https://github.com/open-telemetry/semantic-conventions/blob/b1ad9ae785c3d97cf0c80fe320d9b9156f37e927/.github/CODEOWNERS#L26 ?
requested: https://github.com/open-telemetry/community/issues/2199
this is done now
re-opening, still need to update CODEOWNERS file
Also I realized there's a separate question about logs ownership, so leaving this open
Based on discussions in Logs SIG. Since we merged events and logs into Logs SIG, let's
- rename
open-telemetry/semconv-event-approverstoopen-telemetry/semconv-logs-approvers - make them codeowners on
eventandlognamespaces in the conventions along with general events and logs docs
/cc @open-telemetry/semconv-event-approvers