otel-arrow
otel-arrow copied to clipboard
Pipeline "context" for nodes (& possible duplication)
PR #939 added engine::NodeId which is struct pairing a u16 with a Cow. The unique name in the NodeId is duplicative of the one in the component's engine::config struct.
See #946 also introduces PipelineContext. The new engine::NodeId can be replaced with this.
For example, in engine/config.rs
pub struct ReceiverConfig {
/// Name of the receiver.
pub name: NodeId,
...
(and ProcessorConfig, ExporterConfig). PR #939 introduced a new NodeId in many constructors and in some cases, the engine::NodeId's name does not equal the engine::config value presumably in places where it does not matter.
Should we close this issue?