otel-arrow icon indicating copy to clipboard operation
otel-arrow copied to clipboard

Pipeline "context" for nodes (& possible duplication)

Open jmacd opened this issue 5 months ago • 1 comments

PR #939 added engine::NodeId which is struct pairing a u16 with a Cow. The unique name in the NodeId is duplicative of the one in the component's engine::config struct.

See #946 also introduces PipelineContext. The new engine::NodeId can be replaced with this.

For example, in engine/config.rs

pub struct ReceiverConfig {
    /// Name of the receiver.
    pub name: NodeId,
...

(and ProcessorConfig, ExporterConfig). PR #939 introduced a new NodeId in many constructors and in some cases, the engine::NodeId's name does not equal the engine::config value presumably in places where it does not matter.

jmacd avatar Aug 19 '25 23:08 jmacd

Should we close this issue?

lquerel avatar Oct 09 '25 01:10 lquerel