opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

[i18n] Localize "page not translated" banner

Open chalin opened this issue 10 months ago • 13 comments

This is a followup to #6287. The goal will be to display the banner text in the appropriate local.

Tasks

  • [x] es - #6763
  • [x] fr - #7683
  • [x] pt
    • [x] #6300
    • [x] #6339
  • [x] bn #7685
  • [ ] ja
  • [x] uk #7684
  • [ ] zh

chalin avatar Feb 11 '25 13:02 chalin

I'm working on this for pt but I can't see it working on the deploy preview.

Where should we put the file? Tried some alternatives, none of them worked:

  • /layouts/pt/docs/td-content-after-header.html
  • /layouts/docs/pt/td-content-after-header.html
  • /layouts/docs/pt/docs/td-content-after-header.html

vitorvasc avatar Feb 12 '25 16:02 vitorvasc

Thanks @vitorvasc. I haven't decided how to setup the locale-specific banner messages yet. So for now, just providing the updated text would be great! 🙌🏻

chalin avatar Feb 12 '25 16:02 chalin

@chalin , here are the texts for the French and Spanish versions:

  • fr: Vous consultez la traduction automatique de la version anglaise car cette page n'a pas encore été traduite dans votre langue par notre équipe. Vous souhaitez apporter votre aide ? Consultez la page "Contribuer".
  • es : Estás viendo la traducción automática de la versión en inglés, ya que esta página aún no ha sido traducida por nuestro equipo. ¿Te gustaría ayudar? Consulta la página 'Contribuir'

iguitton avatar Feb 13 '25 07:02 iguitton

@iguitton - oh, now that I've read the messages that you provided, I see that there's been a misunderstanding. Fallback pages will have a single message that will not be changed (by the OTel.io site) whether the user decides to enable Google translate or not. So, if you wish to provide a translation, it should be a translation of the text given in https://github.com/open-telemetry/opentelemetry.io/pull/6287/files.

chalin avatar Feb 15 '25 16:02 chalin

Hey @chalin,

Do you have any updates on how we want to set up the locale-specific banner messages? I'd be happy to add the es translation for the banner.

danielmasegosa avatar Apr 18 '25 22:04 danielmasegosa

Hi @danielmasegosa. Yes, create content/es/_includes/page-not-translated-msg.md. For an example, see https://github.com/open-telemetry/opentelemetry.io/blob/main/content/pt/_includes/page-not-translated-msg.md?plain=1. You'll want to create a Spanish version of https://github.com/open-telemetry/opentelemetry.io/blob/main/content/en/_includes/page-not-translated-msg.md?plain=1.

chalin avatar Apr 24 '25 20:04 chalin

I'd be happy to do it! @chalin

I also started translating the contributing page into Spanish. Is there any issue tracking this kind of translation work, or should I just go ahead and create a PR?

danielmasegosa avatar Apr 24 '25 22:04 danielmasegosa

@danielmasegosa - coordinate with @open-telemetry/docs-es-approvers (such as @krol3 and @theletterf) for the process used by the es locale. Cheers!

chalin avatar Apr 25 '25 14:04 chalin

I've created the PR for this here

danielmasegosa avatar Apr 27 '25 10:04 danielmasegosa

Hi @chalin, the PR for the Spanish banner is now merged. We can mark the es check in this issue as done! 🚀

danielmasegosa avatar Apr 29 '25 18:04 danielmasegosa

Added the French version in https://github.com/open-telemetry/opentelemetry.io/pull/7683.

vitorvasc avatar Sep 02 '25 12:09 vitorvasc

We're still missing translations for the following locales:

  • ja @open-telemetry/docs-ja-approvers
  • zh @open-telemetry/docs-zh-approvers
  • bn @badhon495 @sajibAdhi
  • uk @Andygol @idvoretskyi

Could you help us with the missing parts so we can tackle this issue? 🙌🏼

You can either:

  • Open a PR adding the translated file under content/[XX]/_includes/page-not-translated-msg.md (see this example), or
  • Simply reply to this issue with the translated message for this file, and I'll create the PR 🙂

Thanks!

vitorvasc avatar Sep 02 '25 12:09 vitorvasc

@vitorvasc Feel free to pick translated into Ukrainian file here https://github.com/open-telemetry/opentelemetry.io/blob/79ae827c1c4ee4fee7559b2f8654bd35b381f4f1/content/uk/_includes/page-not-translated-msg.md or approve and merge ultimate Ukrainian translation 👉 https://github.com/open-telemetry/opentelemetry.io/pull/5891

Andygol avatar Sep 02 '25 13:09 Andygol