open-telemetry
✅ [outreachy] feat: no search entries found page (#5372)
Closes #5372
This PR creates a new and better search result page when the is no seach found.
Steps to view work
- Go to the registry page /ecosystem/registry
- Enter a word in the search bar which does not exist (e.g juice)
- View the new designed user interface
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: JennySimen / name: Jennifer Yakam (5bc76003d10e668408d4f407caa3769248af6c87, 5fff1e8cea5ad30d002e368592ffa9048d134b93, 01c5e2247dcdd676df96d94a0607460091c08e21, d4f53ce5a2b5388cf9ffdaeaacf4f3a96dbd020f, dbaad9850cdf30ccc3e0b7a6373008784adb1832, e53a5e790af9c97a2e01f417f6aaabc35ed5a064, 476dbd3ba1e1b471c9697b5355e643bfb7b88cb1, 6163ac4995fbc4221e8bfe393470ff2faa4242b7, dd40dfb1d7f8bfb45cf81a6d887802773ffc8ceb)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
@JennySimen we are currently discussion https://github.com/open-telemetry/opentelemetry.io/issues/5681 to enable the import of the 3rd party image, after this being resolved we should be able to merge your PR
@JennySimen apologies for the delay and for going back and forth. I agree with @chalin's point in this comment (https://github.com/open-telemetry/opentelemetry.io/issues/5681#issuecomment-2518432557) that we should avoid adding the overhead of an image that needs attribution and a license reference in our code. It's much easier in docs/blog text since we simply can put a copy right notice below the image.
I copy the relevant part of the discussion:
Stepping back a bit regarding the original PR: have we considered using just a Font Awesome icon instead, or a completely-free-and-no-license-hassle stock image source?
the font awesome icons might be too small/minimalistic, I like the idea of the image, of course someone with a telescope not finding what they are looking for would be my preferred image. We could also use a variant of
https://opentelemetry.io/homepage-hero-as-background_hu13043826424429285166.jpg
WDYT?
Hi @svrnm, I think it's a great idea to use the above image instead.
I saw that you requested my review, but nothing has changed, can you update the image as discussed? Thanks
Hi @svrnm I have updated the image
I couldn't see that when I checked earlier today, now I do. See @chalin's feedback. It would also be great if the image is not black but aligns with the dark/light mode background, so you might need to edit that image, or we need to see if we can find a version with a light background
Hi @svrnm, as per the feedback from @chalin concerning the image, it will be great if I could please get a version of the image with a lighter background to use since I have not been able to edit it.
Hi @svrnm, as per the feedback from @chalin concerning the image, it will be great if I could please get a version of the image with a lighter background to use since I have not been able to edit it.
@tedsuo - can you help here. I think that you're the one who created the original artwork.
@JennySimen - there are a few GitHub actions that are failing, such as: https://github.com/JennySimen/opentelemetry.io/actions/runs/13519263866
Could you refresh your fork, and disable those workflows? I keep getting failed workflow notifications from your fork. Thanks. /cc @trask
Hi @svrnm, as per the feedback from @chalin concerning the image, it will be great if I could please get a version of the image with a lighter background to use since I have not been able to edit it.
@tedsuo - can you help here. I think that you're the one who created the original artwork.
Hi @tedsuo, is there anything from my side needed to have the lighter backgorund artwork?
@JennySimen - there are a few GitHub actions that are failing, such as: https://github.com/JennySimen/opentelemetry.io/actions/runs/13519263866
Could you refresh your fork, and disable those workflows? I keep getting failed workflow notifications from your fork. Thanks. /cc @trask
Hi @chalin I have disabled the workflows as requested
Hi @tedsuo, is there anything from my side needed to have the lighter backgorund artwork?
Let me ping @tedsuo @austinlparker et all on Slack to see if we can get response.
The hero artwork was commissioned years ago, I forget by whom (or even if they have the originals any more -- IIRC I don't think I got a psd for it, just PNGs?)
Looking at this thread, why not just use a FOSS icon library then scale up the icon? They are vector images after all.
Actually found a way using CSS filter: brightness(3.6):
It would be great to not have to duplicate the image, and just use the CSS, but for starters, set it up with the image above.
apologies for the huge delay once again, I was out of office for an extended period and I am just picking up some work I left behind. @JennySimen are you still open to push this forward?
Currently the PR is blocked by not building properly, so maybe you want to look into the errors, there seems to be a dependency issue with themes/docsy, you can try to bring your PR up in sync with main and then locally run npm run fix:submodule to see if you can get it working. If not ping me and I can run this for you
@svrnm doing some changes to the code and having some issue with git but will update the PR soon.
@JennySimen it might be easier for you to close this PR and start with a new one since the repo has changed a lot since you started working on that.
Let me know if you need any assistance with git/github, ideally ask on slack
@JennySimen I will close this PR for now, you can either reopen it or raise a new one to continue. Thanks