opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard
verified publisher icon open-telemetry

✅ [outreachy] Redesign labels to be distinguishable from actual buttons

Open coyewole opened this issue 1 year ago • 5 comments

Details

This PR implements a redesign of the labels used in the registry components to ensure that labels and buttons are easily identifiable, preventing any confusion between interactive and non-interactive elements.

Before

Screenshot from 2024-10-18 08-36-23

After

Screenshot from 2024-10-18 08-20-35

Fixes #5306

coyewole avatar Oct 18 '24 07:10 coyewole

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Comfyydev / name: Comfort Oyewole (3ee857871ff2f889aa2f2b04117dc1a2892dbe3f)

linux-foundation-easycla[bot] avatar Oct 18 '24 07:10 linux-foundation-easycla[bot]

@svrnm Could you please review my PR? Thanks.

coyewole avatar Oct 18 '24 07:10 coyewole

@svrnm I've updated the PR and implemented the requested changes. Could you please review it? Thanks.

coyewole avatar Oct 18 '24 12:10 coyewole

@Comfyydev overall this looks good to me now, can you run npm run fix:all locally to make sure that all the CI checks pass, afterwards I am happy to accept this task as done.

svrnm avatar Oct 21 '24 08:10 svrnm

I consider this as done! After the outreachy application phase we will take another look and see if we can merge this PR. Thank you!

svrnm avatar Oct 21 '24 15:10 svrnm

@Comfyydev thanks for working on this once again. Since we are turning those badges into working links, this PR is conflicting with the change, so I will close it.

svrnm avatar Nov 22 '24 11:11 svrnm