opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

Added Zero code image

Open mercybassey opened this issue 1 year ago • 8 comments

This PR adds an illustration for Open telemetry zero code.

Issue: #5354

mercybassey avatar Oct 15 '24 13:10 mercybassey

Hi @svrnm, I'm having trouble displaying the image. I checked most of the markdown files in the project, and it seems that images are added using this syntax: ![](). However, this method isn't working for me. Here is the output I'm getting: zero

I'd appreciate your guidance on this.

mercybassey avatar Oct 15 '24 13:10 mercybassey

Do the following:

  • create a new folder zero-code
  • move zero-code.md into that folder and rename the file to index.md
  • move the image into that folder as well

Can you use the SVG instead of the png? This allows us to edit the image in the future much easier and most modern browser render SVGs just fine.

svrnm avatar Oct 15 '24 14:10 svrnm

@svrnm here is my output locally:

zero

mercybassey avatar Oct 15 '24 15:10 mercybassey

@svrnm I have addressed your comments. zero Thanks.

mercybassey avatar Oct 15 '24 18:10 mercybassey

@mercybassey thanks, this looks good! I asked @open-telemetry/docs-approvers to take a look as well, so that we have at least one more person to take a look

svrnm avatar Oct 16 '24 06:10 svrnm

@mercybassey thanks, this looks good! I asked @open-telemetry/docs-approvers to take a look as well, so that we have at least one more person to take a look

Great.

mercybassey avatar Oct 16 '24 06:10 mercybassey

@mercybassey apologies for the delay here. We need to discuss the details a little bit more before we can get this merged. This will unfortunately not happen before the end of the contribution phase for outreachy. So, assume this as "done" for your application and if you are still interested we can follow up later.

svrnm avatar Oct 25 '24 06:10 svrnm

@mercybassey apologies for the delay here. We need to discuss the details a little bit more before we can get this merged. This will unfortunately not happen before the end of the contribution phase for outreachy. So, assume this as "done" for your application and if you are still interested we can follow up later.

Alright. I’m cool with that. Thanks.

mercybassey avatar Oct 25 '24 06:10 mercybassey

@mercybassey apologies for the delay, we had to skip some of our last meetings, hopefully we will get to this on Monday!

svrnm avatar Nov 22 '24 11:11 svrnm

@mercybassey apologies for the delay, we had to skip some of our last meetings, hopefully we will get to this on Monday!

Great. Thank you.

mercybassey avatar Nov 22 '24 13:11 mercybassey

@mercybassey apologies for the delay, we had to skip some of our last meetings, hopefully we will get to this on Monday!

Great. Thank you.

Unfortunately @chalin is out of office, I will follow up with him to talk this through to give you further feedback. Apologies for the further delay

svrnm avatar Nov 26 '24 10:11 svrnm

@svrnm - I defer to you on the acceptance of this image as is. Could we at least ensure that it is compatible with dark mode from the outset, which it currently is not:

Thanks! I think this image is a good starting point on which we can iterate. I agree that it should be compatible with dark mode as well, this is accomplished best with a transparent background

@mercybassey please take a look

svrnm avatar Dec 05 '24 09:12 svrnm

@svrnm - I defer to you on the acceptance of this image as is. Could we at least ensure that it is compatible with dark mode from the outset, which it currently is not:

Thanks! I think this image is a good starting point on which we can iterate. I agree that it should be compatible with dark mode as well, this is accomplished best with a transparent background

@mercybassey please take a look

Sure @svrnm. I'll adjust the image and use a transparent background instead. Thanks.

mercybassey avatar Dec 05 '24 11:12 mercybassey

Hi @svrnm @chalin. I have adjusted the image. Below is the image in dark and light mode. dark-mode light-mode

mercybassey avatar Dec 05 '24 14:12 mercybassey

Hi @svrnm @chalin. I have adjusted the image. Below is the image in dark and light mode. dark-mode light-mode

I noticed that most images have a transparent boundary, so I decided to leave it as is unless instructed otherwise. example2 example1

mercybassey avatar Dec 05 '24 14:12 mercybassey

thank you for your contribution and your patience @mercybassey !

svrnm avatar Dec 09 '24 08:12 svrnm