Added Zero code image
This PR adds an illustration for Open telemetry zero code.
Issue: #5354
Hi @svrnm, I'm having trouble displaying the image. I checked most of the markdown files in the project, and it seems that images are added using this syntax: ![](). However, this method isn't working for me. Here is the output I'm getting:
I'd appreciate your guidance on this.
Do the following:
- create a new folder
zero-code - move
zero-code.mdinto that folder and rename the file toindex.md - move the image into that folder as well
Can you use the SVG instead of the png? This allows us to edit the image in the future much easier and most modern browser render SVGs just fine.
@svrnm here is my output locally:
@svrnm I have addressed your comments.
Thanks.
@mercybassey thanks, this looks good! I asked @open-telemetry/docs-approvers to take a look as well, so that we have at least one more person to take a look
@mercybassey thanks, this looks good! I asked @open-telemetry/docs-approvers to take a look as well, so that we have at least one more person to take a look
Great.
@mercybassey apologies for the delay here. We need to discuss the details a little bit more before we can get this merged. This will unfortunately not happen before the end of the contribution phase for outreachy. So, assume this as "done" for your application and if you are still interested we can follow up later.
@mercybassey apologies for the delay here. We need to discuss the details a little bit more before we can get this merged. This will unfortunately not happen before the end of the contribution phase for outreachy. So, assume this as "done" for your application and if you are still interested we can follow up later.
Alright. I’m cool with that. Thanks.
@mercybassey apologies for the delay, we had to skip some of our last meetings, hopefully we will get to this on Monday!
@mercybassey apologies for the delay, we had to skip some of our last meetings, hopefully we will get to this on Monday!
Great. Thank you.
@mercybassey apologies for the delay, we had to skip some of our last meetings, hopefully we will get to this on Monday!
Great. Thank you.
Unfortunately @chalin is out of office, I will follow up with him to talk this through to give you further feedback. Apologies for the further delay
@svrnm - I defer to you on the acceptance of this image as is. Could we at least ensure that it is compatible with dark mode from the outset, which it currently is not:
Thanks! I think this image is a good starting point on which we can iterate. I agree that it should be compatible with dark mode as well, this is accomplished best with a transparent background
@mercybassey please take a look
@svrnm - I defer to you on the acceptance of this image as is. Could we at least ensure that it is compatible with dark mode from the outset, which it currently is not:
Thanks! I think this image is a good starting point on which we can iterate. I agree that it should be compatible with dark mode as well, this is accomplished best with a transparent background
@mercybassey please take a look
Sure @svrnm. I'll adjust the image and use a transparent background instead. Thanks.
Hi @svrnm @chalin. I have adjusted the image. Below is the image in dark and light mode.
Hi @svrnm @chalin. I have adjusted the image. Below is the image in dark and light mode.
![]()
I noticed that most images have a transparent boundary, so I decided to leave it as is unless instructed otherwise.
thank you for your contribution and your patience @mercybassey !
