opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

feat: [es] Create docs/languages/js/_index.md

Open oayras opened this issue 1 year ago • 2 comments

Related issue https://github.com/open-telemetry/opentelemetry.io/issues/5229

oayras avatar Oct 05 '24 06:10 oayras

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: oayras / name: Oscar Ayra (521911961884b178eb3c225731b4aaf4a387cda9, 910c6e314f384312c7c1e1fe9e37e6b6420d6f37, 01b1b366b45b6c4f064205e1c56f974ba7f3a5d8, d73267469f232b2f7a53e9eca1d0b79d78cf58a5, 81b73a88e0aa6d54b7fc63943c5f213cd8a7c029)

+CC @krol3

theletterf avatar Oct 08 '24 05:10 theletterf

@oayras Could you check the comments? Thanks!

theletterf avatar Oct 30 '24 08:10 theletterf

@oayras Could you check the comments? Thanks!

@theletterf, in the following commits, I’ve corrected the observations you made previously: I translated the description and the shortcode. Could you let me know if you have any further feedback, please?

oayras avatar Oct 31 '24 03:10 oayras

Issues in I18N check fixed and conflict from merge was resolved!

oayras avatar Nov 03 '24 04:11 oayras

/fix:all

theletterf avatar Nov 04 '24 07:11 theletterf

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11659573015

opentelemetrybot avatar Nov 04 '24 07:11 opentelemetrybot

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

opentelemetrybot avatar Nov 04 '24 07:11 opentelemetrybot

default_lang_commit value was fixed

oayras avatar Nov 06 '24 03:11 oayras

This PR needs to be rebased. /cc @theletterf

chalin avatar Nov 13 '24 11:11 chalin

This PR needs to be rebased. /cc @theletterf

I've rebased and resolved conflicts as best I could. PTAL

chalin avatar Nov 13 '24 11:11 chalin

@theletterf et all: in general, please tag me on localization PRs that have such a "broad" (cross-localization) impact and/or changes to shared layouts so that we can together assess and discuss design alternatives.

Hugo has built-in support for i18n, in the way that you've implemented it here. So we don't need to re-implement our own localization tag support.

I need to think about this a bit more before I can make some concrete suggestions. Stay tuned!

chalin avatar Nov 13 '24 11:11 chalin

Closing as issues weren't addressed.

theletterf avatar Jan 10 '25 08:01 theletterf