opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

Search results pane ignores dark/auto mode

Open Kielek opened this issue 1 year ago • 2 comments

What happened? Search page ignores dark/auto mdoe image

What did you expect would happen? Dark/auto mode is supported by search. Google is able to render dark modes.

What is the name + path of the page where you encountered the issue? Search Result: https://opentelemetry.io/search/?q=test#gsc.tab=0&gsc.q=test&gsc.page=1

What browser, OS, and platform were you using when you encountered the problem? Win11, Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Additional context: I suppose that fixes needs to go to the docsy repository.

Kielek avatar Jul 02 '24 06:07 Kielek

@chalin Sounds like we'd override those classes in our CSS?

theletterf avatar Jul 02 '24 08:07 theletterf

That content is generated by Google. I can't recall the details. Will need to investigate.

chalin avatar Jul 02 '24 21:07 chalin

I have a solution, I'll just need to upstream it to Docsy and/or migrate it here:

  • https://github.com/jaegertracing/documentation/pull/1018

chalin avatar Nov 11 '25 20:11 chalin

Fixed via #8495, see https://deploy-preview-8495--opentelemetry.netlify.app/search/?q=collector:

Image

chalin avatar Nov 24 '25 01:11 chalin

Nice, thanks!

Kielek avatar Nov 24 '25 05:11 Kielek

awesome, thank you:-)

svrnm avatar Nov 24 '25 07:11 svrnm

We still need to merge #8495 thought :)

chalin avatar Nov 24 '25 07:11 chalin