open-telemetry
Blog: Blog post for scaling OpenTelemetry Collectors using Ansible
This continues https://github.com/open-telemetry/opentelemetry.io/pull/4140
@ishanjainn I've mixed feelings about this post. Half of the post is about Grafana while it claims to be about Ansible. Can we make it more specific to Ansible?
@ishanjainn I've mixed feelings about this post. Half of the post is about Grafana while it claims to be about Ansible. Can we make it more specific to Ansible
Hey thanks for the review! So the main point is to scale the collectors and only added Grafana (OSS) as the platform to view metrics as thats what seemed simplar. I just added clear steps to monitor in grafana as @svrnm suggested in my previous PR which I had to close
@ishanjainn I made a direct commit to simplify some bits. In its current form, I approve the content. Notice that I've removed unnecessary links — folks usually know how to google for Grafana and Docker.
@svrnm whats your take on adding couple links to Grafana? Right now we have zero link outs to either grafana installation or anything which seems a bit odd to me even as a reader
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8342087874
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ishanjainn Those links seem to be there more for SEO than for usefulness. Given the bias toward Grafana in the post, I think removing generic links will balance the odds.
@ishanjainn Those links seem to be there more for SEO than for usefulness. Given the bias toward Grafana in the post, I think removing generic links will balance the odds.
Not really for SEO tbh, Was mainly to help readers(have proper instructions) but Im okay if everyone thinks its not needed. Not a big issue on my end
@ishanjainn Got it. Feel free to restore a link to OSS Grafana. I've already approved the PR. Another approval will be needed.
hey @theletterf Thanks, Ive added the link and also rephrased the Inventory file section a bit, simplified it mainly
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8439815271
@theletterf Can I tag anyone specific for the second review, Wanna get this ready for merge?
Thanks for the detailed review @chalin and apologies for not following up @ishanjainn, I was out of office for the last few weeks (including KubeCon). I think this is already in a good shape, if you can address @chalin's feedback we should be good, especially take a look at the comment around "delivering what the blog promises", this is a valid point that by fixing will make your blog signficiantly better.
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8667719139
You'll have a few linter and spelling issues to fix, but it should be good after that.
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8686040782
You triggered fix:dict action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8686222218
@ishanjainn thanks for writing this up and working with us through the copy editing, your blog post is live now!
Hey @svrnm, If I wanted to add a meta image to the blog, Can I edit this in a PR and get that included too or that would not be possible to update now?