opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

updated connector readme

Open MinalAC opened this issue 1 year ago • 3 comments

Updated the connector.md to mention that servicegraph and spanmetrics processors are now deprecated and replaced by connectors as mentioned in the open-telemetry releases page.

MinalAC avatar Mar 03 '24 14:03 MinalAC

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: cartermp / name: Phillip Carter (344df6c4879567df4868257a580307f98ba1e670, bfce54dc6c172ed0d153ecdcfd478fd0d1623c5f)
  • :white_check_mark: login: MinalAC / name: hime (345307ff9c3eec2365523c57a6d4fb5e8b9f0eb3)

thanks for your contribution @MinalAC !

I wonder if we need to make it clearer from the start of the paragraph that the processors are historically. Maybe we lead with

Before collector version X processors have been used to converte telemetry data of one type into another one. A few examples are the now depreacted spanmetrics processor, as well as the servicegraph processor. [...]

svrnm avatar Mar 04 '24 09:03 svrnm

@svrnm Okay, but to mention this -- "Before collector version X processors have been used..." , is it the case that all the processors got replaced by collectors or only those two(servicegraph and spanmetrics ) got replaced by the collectors and there are no more processors used?

MinalAC avatar Mar 07 '24 17:03 MinalAC

Could we merge this one?

theletterf avatar Apr 04 '24 08:04 theletterf

I think we should just merge this given the time it's been open.

cartermp avatar Apr 04 '24 14:04 cartermp