add comments of springboot 3.0 minimum JDK version
fix 1 of https://github.com/open-telemetry/opentelemetry.io/issues/3765
Preview: https://deploy-preview-3906--opentelemetry.netlify.app/docs/languages/java/instrumentation/
@chalin I suggested to @pegasas to look into the issue, so apologies for creating confusion. Shouldn't we add a prerequisites section to that page as well, at least for the example app, or is this creating too much confusion (aka people thinking that is required for ALL of otel)
@svrnm - no worries, I just wanted to make sure that we were all aware that a similar change had been done elsewhere, and give us an opportunity to think if we want to try to avoid duplication yet (which we might not).
@svrnm - no worries, I just wanted to make sure that we were all aware that a similar change had been done elsewhere, and give us an opportunity to think if we want to try to avoid duplication yet (which we might not).
Thanks @chalin and @svrnm for clarification. At least now we know that 1 is resolved now. And also I will tried these samples for fixing 3 and rethink a mechanism to avoid duplication yet (which we might not).
I will close this later~ Thank you so much
I think that it would be better, as you suggest, to add a Prerequisites section similar to https://opentelemetry.io/docs/languages/java/getting-started/#prerequisites.
I will close this later~
Hi @pegasas - no need to close it, you can just apply the suggested changes directly to this PR IMHO.
I will close this later~
Hi @pegasas - no need to close it, you can just apply the suggested changes directly to this PR IMHO.
Thanks. Due to there are 2 options Gradle/Maven below, I made some minus change about that.
/fix:all
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669
fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669 for details
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669
fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669 for details
/fix:all
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7920078072
thanks @pegasas ! @open-telemetry/java-approvers PTAL!
@open-telemetry/java-approvers PTAL!
/fix:format
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8622439178
@jack-berg - we good to go here?
@pegasas thank you very much for this contribution!