opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

add comments of springboot 3.0 minimum JDK version

Open pegasas opened this issue 1 year ago • 15 comments

fix 1 of https://github.com/open-telemetry/opentelemetry.io/issues/3765


Preview: https://deploy-preview-3906--opentelemetry.netlify.app/docs/languages/java/instrumentation/

pegasas avatar Jan 31 '24 12:01 pegasas

@chalin I suggested to @pegasas to look into the issue, so apologies for creating confusion. Shouldn't we add a prerequisites section to that page as well, at least for the example app, or is this creating too much confusion (aka people thinking that is required for ALL of otel)

svrnm avatar Jan 31 '24 12:01 svrnm

@svrnm - no worries, I just wanted to make sure that we were all aware that a similar change had been done elsewhere, and give us an opportunity to think if we want to try to avoid duplication yet (which we might not).

chalin avatar Jan 31 '24 13:01 chalin

@svrnm - no worries, I just wanted to make sure that we were all aware that a similar change had been done elsewhere, and give us an opportunity to think if we want to try to avoid duplication yet (which we might not).

Thanks @chalin and @svrnm for clarification. At least now we know that 1 is resolved now. And also I will tried these samples for fixing 3 and rethink a mechanism to avoid duplication yet (which we might not).

I will close this later~ Thank you so much

pegasas avatar Jan 31 '24 13:01 pegasas

I think that it would be better, as you suggest, to add a Prerequisites section similar to https://opentelemetry.io/docs/languages/java/getting-started/#prerequisites.

chalin avatar Jan 31 '24 13:01 chalin

I will close this later~

Hi @pegasas - no need to close it, you can just apply the suggested changes directly to this PR IMHO.

chalin avatar Jan 31 '24 13:01 chalin

I will close this later~

Hi @pegasas - no need to close it, you can just apply the suggested changes directly to this PR IMHO.

Thanks. Due to there are 2 options Gradle/Maven below, I made some minus change about that.

pegasas avatar Jan 31 '24 15:01 pegasas

/fix:all

chalin avatar Feb 15 '24 17:02 chalin

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669

github-actions[bot] avatar Feb 15 '24 17:02 github-actions[bot]

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669 for details

github-actions[bot] avatar Feb 15 '24 17:02 github-actions[bot]

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669

github-actions[bot] avatar Feb 15 '24 17:02 github-actions[bot]

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/7919760669 for details

github-actions[bot] avatar Feb 15 '24 17:02 github-actions[bot]

/fix:all

chalin avatar Feb 15 '24 17:02 chalin

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7920078072

github-actions[bot] avatar Feb 15 '24 17:02 github-actions[bot]

thanks @pegasas ! @open-telemetry/java-approvers PTAL!

svrnm avatar Feb 16 '24 11:02 svrnm

@open-telemetry/java-approvers PTAL!

cartermp avatar Feb 16 '24 14:02 cartermp

/fix:format

chalin avatar Apr 09 '24 21:04 chalin

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8622439178

github-actions[bot] avatar Apr 09 '24 21:04 github-actions[bot]

@jack-berg - we good to go here?

chalin avatar Apr 09 '24 21:04 chalin

@pegasas thank you very much for this contribution!

svrnm avatar Apr 19 '24 07:04 svrnm