opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

Feature Flag Service

Open agardnerIT opened this issue 2 years ago • 7 comments

Is this sentence still true:

This service is written in Erlang/Elixir and it is responsible for creating,
reading, updating and deleting feature flags in a PostgreSQL DB.
It is called by Product Catalog and Shipping services.

The current architecture diagram suggests it is called by many more now:

https://opentelemetry.io/docs/demo/architecture/

happy to create a PR

agardnerIT avatar Aug 24 '23 01:08 agardnerIT

@agardnerIT please create a PR! We can just remove that last sentence.

cartermp avatar Aug 24 '23 17:08 cartermp

is this still the case? @agardnerIT , @open-telemetry/demo-approvers ?

svrnm avatar Jan 18 '24 07:01 svrnm

@svrnm, it's called by other services as well. I think this sentence is unnecessary detail, hard to keep updated, and could be removed: It is called by Product Catalog and Shipping services.

mviitane avatar Jan 18 '24 14:01 mviitane

I agree with @mviitane . It would be best to remove that sentence.

puckpuck avatar Jan 18 '24 15:01 puckpuck

thanks @mviitane , @puckpuck , anyone of you open to provide the PR?

svrnm avatar Jan 18 '24 18:01 svrnm

We are making several changes to how the feature flag service is configured which will also require some docs changes. Let's make sure to do this as part of those changes as well.

puckpuck avatar Jan 19 '24 00:01 puckpuck

thanks

svrnm avatar Jan 19 '24 08:01 svrnm

Feature flag has been removed recently (https://github.com/open-telemetry/opentelemetry.io/issues/4265). Closing.

theletterf avatar Apr 09 '24 11:04 theletterf