opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

Low contrast hyperlink in the dark background sections

Open raunaqgupta opened this issue 3 years ago • 3 comments

Desired feature or idea. Improve hyperlink color when inside dark background sections. They currently also fail all WCAG levels.

image

raunaqgupta avatar Oct 14 '22 21:10 raunaqgupta

@chalin and @Arhell any thoughts?

cartermp avatar Oct 14 '22 22:10 cartermp

+1 for making a fix to this issue: improving the accessibility of the site helps make OTel more inclusive to the community.

melbgirl avatar Oct 15 '22 01:10 melbgirl

@cartermp if we decide we do want to make a change, I'm happy to take this issue.

melbgirl avatar Oct 15 '22 02:10 melbgirl

@raunaqgupta do you recommend the site handling the two modes (ie behaving one way for dark mode, behaving differently for light mode), or simply changing the URL coloring so that it can be perceived in either dark or light mode?

melbgirl avatar Oct 20 '22 01:10 melbgirl

I would recommend just updating colors so contrast is the so bad. IIRC we don't have a dark mode for the site.

cartermp avatar Oct 20 '22 18:10 cartermp

https://github.com/open-telemetry/opentelemetry.io/blob/f5fc3c0a8d965794e4500bff85656511cf107c17/assets/scss/_styles_project.scss#L122-L125

Here's the file/style where the a color is specifically being set for dark and secondary sections. My suggestions are to:

  1. Separate dark and secondary
  2. Update hyperlink for dark
  3. I personally feel the secondary section is too yellow and can be toned down a bit
  4. Update the hyperlink color (if needed after 3) for the secondary section.

I'll send a PR soon.

raunaqgupta avatar Oct 20 '22 22:10 raunaqgupta

PR merged, thanks! I'll submit a followup PR for the remaining issues: #1916, doesn't fix the contrast on the Registry page, for example.

chalin avatar Oct 27 '22 13:10 chalin

Here's the PR which, if y'all agree, should close this issue:

  • #1937

chalin avatar Oct 27 '22 14:10 chalin