opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

Switch to using Docy's tabbed panes

Open chalin opened this issue 3 years ago • 4 comments

Docy has a flexible implementation of tabbed panes that, for example supports both code and text in a tab. I suggest that we drop our own custom implementation of tabs and upgrade to Docsy's.

WDYT @svrnm @cartermp @austinlparker? I'd like your thumbs up before I start on this cleanup.

We only have about 4 files so the upgrade wouldn't be too painful, but more files are being updated (e.g., #1800) to use tabs, so if we're going to do this I think it would be better sooner than latter :).

chalin avatar Oct 06 '22 22:10 chalin

Yes, please! This would allow for use of rewrap on the relevant files if code moves to code blocks.

cartermp avatar Oct 07 '22 05:10 cartermp

Yes, let's do that!

svrnm avatar Oct 07 '22 06:10 svrnm

Great! Ok, I'll start that as soon as I can (and I'll add a comment to #1772) -- I'm waiting on some Docsy updates before proceeding.

chalin avatar Oct 10 '22 14:10 chalin

Some tabs work with the Docsy tab-related shortcodes, but some don't yet. Waiting on:

  • https://github.com/google/docsy/issues/1271

chalin avatar Oct 10 '22 18:10 chalin