opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

Add TypeScript to "Getting Started"

Open svrnm opened this issue 3 years ago • 7 comments

Child of #1772

@kaiwalyakoparkar

svrnm avatar Oct 04 '22 08:10 svrnm

@kaiwalyakoparkar please comment on this issue so I can assign it to you.

svrnm avatar Oct 04 '22 08:10 svrnm

hey @svrnm 👋 kindly assign this issue to me

kaiwalyakoparkar avatar Oct 04 '22 12:10 kaiwalyakoparkar

Done

svrnm avatar Oct 04 '22 13:10 svrnm

Hey @svrnm Thank you. Can you please tell me the file location I need to update (The previous issue has been updated hence I lost track of file I need to update

kaiwalyakoparkar avatar Oct 04 '22 13:10 kaiwalyakoparkar

https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/instrumentation/js/getting-started

Most important one is nodejs. You can do browser as well.

svrnm avatar Oct 04 '22 13:10 svrnm

@svrnm perfect! few more things.

  1. The content written on the page is just for nodejs. Do I need to change that to be generic to ts as well?
  2. How do I check out if the tab thing is working (The default vs code preview does not render it as tabs)

kaiwalyakoparkar avatar Oct 04 '22 13:10 kaiwalyakoparkar

  1. Yes, make sure that it works with TS as well. So if you need additional dependencies then list them. This means also the shell code will need tabbing.
  2. After cloning and pulling the repo on your local machine run npm run serve. This will start a local dev copy for you with auto refresh etc.

svrnm avatar Oct 04 '22 14:10 svrnm

Done!

cartermp avatar Nov 11 '22 18:11 cartermp