opentelemetry.io icon indicating copy to clipboard operation
opentelemetry.io copied to clipboard

Adds cookie- / privacy-policy consent support

Open chalin opened this issue 3 years ago • 3 comments

  • Contributes to #1636
  • Features:
    • Displays a modal dialog that is centered in the page (works well on desktop and mobile).
    • The only way to dismiss the dialog is by clicking the "accept" button (the green check mark). So, the site cannot be used without a consent.
    • Tab-focus goes to the accept button.
  • A first attempt at addressing GDPR requirements. If there is general agreement on moving forward with this I'll make some followup changes such as (most items, other than the first, are mainly a note-to-self):
    • Only enabling this for production builds. WDYT?
    • Moving the currently hard-coded styling into our SCSS files, and
    • Switch to using FA 6 icon names.
    • I might also propose this as an upstream change to Docsy.

Preview:

  • Any page from the preview server, such as:
    • Homepage: https://deploy-preview-1653--opentelemetry.netlify.app
    • Docs page, e.g.: https://deploy-preview-1653--opentelemetry.netlify.app/docs/instrumentation/go/
    • Blog page, e.g.: https://deploy-preview-1653--opentelemetry.netlify.app/blog/2022/demo-announcement/
  • You can reset the cookie through you browser settings, but also through the JS console using the following commands:
    Cookies.get('linux-foundation-org-cookie-consent')
    Cookies.set('linux-foundation-org-cookie-consent', '')
    
    Or from, say, Chrome DevTools >> Application >> Storage >> Cookies.

/cc @caniszczyk @austinlparker @cartermp

chalin avatar Aug 23 '22 09:08 chalin

Thanks for creating this @chalin! I see some discussion here and at #1636, should we have it here or there?

A few thoughts:

(question) the only cookie I see is the google analytics cookie. Besides google analytics we are using otel itself for tracking. As far as I see it from other websites there needs(?) to be an option to not allow those cookies (and probably also to disable GA & otel tracking). Actually if I remember correctly there's a requirement to have "Opt-In" being the default.

(nice-to-have) Related: I saw some websites recently to start respecting the "Do-Not-Track" header being set, so if we provide a way to disable cookies/tracking, this would be a feature lots of people appreciate.

(nice-to-have) I like the way how the cncf.io solves it having it in the bottom right corner. Is it possible to have it that way? It's getting less into the way of the users.

Screen Shot 2022-08-23 at 12 19 35

svrnm avatar Aug 23 '22 10:08 svrnm

Sure, let's move this broad "how to" discussion to the main issue. See my response here: https://github.com/open-telemetry/opentelemetry.io/issues/1636#issuecomment-1224013483.

chalin avatar Aug 23 '22 12:08 chalin

My main issue with this implementation is:

So, the site cannot be used without a consent.

I'd rather we "lose" views in GA than actually lose people because they couldn't decline.

cartermp avatar Aug 30 '22 01:08 cartermp

As mentioned in the SIG meeting, this is still on my radar, but it seems like we might need to have a broader discussion first?

chalin avatar Dec 19 '22 18:12 chalin

As mentioned in the SIG meeting, this is still on my radar, but it seems like we might need to have a broader discussion first?

Yes:

I agree with @cartermp (I'd rather we "lose" views in GA than actually lose people because they couldn't decline.), but right now we have nothing at all, and since CNCF/LF "force" us to use google analytics, I would say the solution with only the accept button is better than nothing.

svrnm avatar Dec 19 '22 18:12 svrnm

Closing. Will be exploring another route later when I get the time to work on this again.

chalin avatar Nov 02 '23 14:11 chalin