opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Clarify OTEP 4485

Open martincostello opened this issue 3 months ago • 3 comments

Context: https://github.com/open-telemetry/opentelemetry-dotnet/issues/6472#issuecomment-3347761284

It is not clear what second part of the following sentence means:

https://github.com/open-telemetry/opentelemetry-specification/blob/ec3779c3d0044503a1ec07d59bcfcf13d98cf904/oteps/4485-extending-attributes-to-support-complex-values.md?plain=1#L203-L205

martincostello avatar Oct 03 '25 08:10 martincostello

@trask, @lmolkova,

Do you remember what is the below about?

and apply additional settings that enhance serialization stability.

Should we remove this?

pellared avatar Nov 25 '25 18:11 pellared

looks like it came from this discussion: https://github.com/open-telemetry/opentelemetry-specification/pull/4485#discussion_r2060482884

cc @dyladan @lmolkova

trask avatar Nov 25 '25 18:11 trask

Yes. I think the lexicographical sort is sufficient, but @lmolkova was likely just trying to head off any additional concerns that may come up that cause the JSON stringify to not be stable.

dyladan avatar Nov 25 '25 19:11 dyladan