opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Zipkin transformation to support resource and instrumentation scope attributes

Open ysolomchenko opened this issue 9 months ago • 4 comments

Relates to https://github.com/open-telemetry/opentelemetry-dotnet/issues/5936

What are you trying to achieve?

So, there will be two ways to set tags(Span.Attributes):

  • Adding tags directly to the Activity(Span)
  • Adding tags via ActivitySource(Tracing Provider (or Tracer))

We should specify which of these has higher priority.

Additional context.

OpenTelemetry to Zipkin Transformation

I'm happy to update the documentation in a follow-up PR, but I need clarification on which source should take precedence and how collisions should be handled.

ysolomchenko avatar Apr 07 '25 07:04 ysolomchenko

From triage session on 2025-04-07 this is related to #2535 (probably a sub-issue of this?). Since the parent issue needs a sponsor, we are labeling this one in the same way.

We would also like to reword this in terms of the specification-level concepts, since ActivitySource and Activity are .NET specific. Could you reword this @ysolomchenko ?

mx-psi avatar Apr 07 '25 09:04 mx-psi

From triage session on 2025-04-07 this is related to #2535 (probably a sub-issue of this?). Since the parent issue needs a sponsor, we are labeling this one in the same way.

We would also like to reword this in terms of the specification-level concepts, since ActivitySource and Activity are .NET specific. Could you reword this @ysolomchenko ?

Activity corresponds to a Span in tracing specifications, and ActivitySource corresponds to a Tracing Provider (or Tracer).

ysolomchenko avatar Apr 07 '25 09:04 ysolomchenko

I think it is also also unclear how resource attributes collision should be handled. @ysolomchenko, am I correct?

pellared avatar Apr 07 '25 13:04 pellared

I think it is also also unclear how resource attributes collision should be handled. @ysolomchenko, am I correct?

Yes, you are right

ysolomchenko avatar Apr 07 '25 13:04 ysolomchenko