opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Event identifier of an integer type

Open pellared opened this issue 1 year ago • 3 comments

What are you trying to achieve?

It may be good to allow having EventId of an integer type (instead of EventName which is always as string) for performance reasons.

Additional context.

In .NET the EventId is a integer with optional name. https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.eventid.-ctor?view=net-8.0

Also see OTel C++:

  • https://github.com/open-telemetry/opentelemetry-cpp/blob/f69963f587b148d2eb20f7d30f8b4a1ccb184a6f/api/include/opentelemetry/logs/event_id.h

Related to:

  • https://github.com/open-telemetry/opentelemetry-specification/issues/4260

pellared avatar Nov 04 '24 07:11 pellared

I created this issue as I think it was brought up a few times.

My personal opinion, is that for sake of simplicity we should only have Event Name as string for the identifier. The reason is that it is the model of OpenTelemetry Events and not any possible event system/library/software. The OTel Semantic Conventions are using names.

pellared avatar Nov 04 '24 11:11 pellared

removed tc-inbox label since it's a sig-issue

trask avatar Nov 05 '24 21:11 trask

Linking to prior attempts at having a durable identified for Logs(Events): https://github.com/open-telemetry/semantic-conventions/issues/372 https://github.com/open-telemetry/semantic-conventions/pull/1339

cijothomas avatar Nov 19 '24 16:11 cijothomas