opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Probability Samplers based on W3C Trace Context Level 2

Open jmacd opened this issue 1 year ago • 3 comments

Fixes #1413. Fixes #3602.

Changes

Updates Trace SDK and Propagator specifications with complete support for consistent probability sampling as described in OTEP 235.

  • [ ] Related issues #3307, #2253, #2179, #2113, #1947,#1844,
  • [ ] OTEP: https://github.com/open-telemetry/oteps/pull/235
  • [ ] Links to the prototypes https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/29720
  • [ ] CHANGELOG.md TODO
  • [ ] spec-compliance-matrix.md TODO

jmacd avatar Feb 27 '24 23:02 jmacd

@kentquirk @oertl @PeterF778 @kalyanaj Please take a look. I believe a bit more prototyping will be required, so I leave this open as a draft PR. I am looking to prototype an OTel-Go SDK change to the TraceIdRatioBased sampler, and I will be continuing to revive https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/24811 in the coming week. Cheers!

jmacd avatar Feb 27 '24 23:02 jmacd

@kentquirk @oertl @PeterF778 @kalyanaj TL;DR I found about half of the text in the old, experimental specification to be overkill and removed a lot of it. If you see something you'll greatly miss, we can bring it back. @kentquirk if you want to throw out the old, experimental specification and start from scratch, I'm open to that. I don't think we need to extend the specification with all the pseudocode from the OTEP, readers can refer back to that document for details.

jmacd avatar Feb 27 '24 23:02 jmacd

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Mar 12 '24 03:03 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Mar 20 '24 03:03 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Apr 05 '24 03:04 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Apr 13 '24 03:04 github-actions[bot]