opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Reduce entries in spec matrix to make it easier to read

Open cijothomas opened this issue 1 year ago • 4 comments

The spec compliance matrix for Metrics has a lot of entries, and I feel it is too detailed. This PR is proposing to collapse some of them - specifically this PR makes a single entry for "Support Counter instrument", which is implied to indicate everything related to Counter is supported, as opposed to a line entry for each of creation/add/add-with-attribute/value-validation etc. I don't see anything important enough for a user is "lost" with this condensed version.

If I get an okay for this direction, I can continue with doing same for other type of instruments as well. Overall, it'll make it easy for all to follow the matrix, without losing anything....

cijothomas avatar Feb 09 '24 16:02 cijothomas

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Feb 21 '24 03:02 github-actions[bot]

@carlosalberto can you give a thumbs-up/down (as you are the assignee for this by the bot!)

cijothomas avatar Feb 21 '24 17:02 cijothomas

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Mar 04 '24 03:03 github-actions[bot]

Oops, sorry for missing this one. Let's poke the @open-telemetry/specs-metrics-approvers to confirm this is fine.

carlosalberto avatar Mar 06 '24 16:03 carlosalberto

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Mar 14 '24 03:03 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Mar 26 '24 03:03 github-actions[bot]

The more detailed view can be useful to maintainers. But since there isn't a way collapse to make it easier for a user at the same time as keeping it I wouldn't really argue it should stay for that purpose.

tsloughter avatar Apr 02 '24 15:04 tsloughter

Thanks. Given the approvals, I'll spend some time to replicate this for other instruments as well and other places where it makes sense via small PRs.

cijothomas avatar Apr 08 '24 20:04 cijothomas