opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Prometheus compatibility: represent Prometheus Info, StateSet and Unknown-typed metrics in OTLP

Open dashpole opened this issue 1 year ago • 4 comments

Fixes https://github.com/open-telemetry/opentelemetry-specification/issues/3058 Fixes https://github.com/open-telemetry/opentelemetry-specification/issues/1712 Fixes https://github.com/open-telemetry/opentelemetry-specification/issues/2409

Changes

Use metric.metadata (added in https://github.com/open-telemetry/opentelemetry-proto/pull/514) to support representing prometheus metric types in OTLP.

Alternative Considered

We could consider using a metadata key that is not prometheus specific (e.g. gauge.subtype=unknown), but a prometheus-specific key seems better for avoiding collisions with other uses.

@open-telemetry/wg-prometheus

dashpole avatar Feb 07 '24 21:02 dashpole

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Feb 16 '24 03:02 github-actions[bot]

Should this be included in March's release?

carlosalberto avatar Mar 05 '24 16:03 carlosalberto

@carlosalberto I would appreciate that. The only caveat is that the proto changes this is based on haven't been released yet, so this can't actually be implemented yet

dashpole avatar Mar 05 '24 16:03 dashpole

Aha! yes, I had forgotten about the proto not releasing yet the related update. WDYT @jsuereth ?

carlosalberto avatar Mar 06 '24 14:03 carlosalberto

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Mar 14 '24 03:03 github-actions[bot]

@carlosalberto I think we need to release the proto directory....

jsuereth avatar Mar 21 '24 13:03 jsuereth

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Apr 02 '24 03:04 github-actions[bot]

Merging as proto 1.2.0 with metric.metadata has been released.

carlosalberto avatar Apr 08 '24 14:04 carlosalberto