opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Refine description of Instrumentation Scope for Logs

Open pellared opened this issue 1 year ago • 1 comments

Fixes https://github.com/open-telemetry/opentelemetry-specification/issues/3841

Changes

  • Update "Instrumentation Scope" term in glossary.
  • Update "Attribute Collections" (in common definitions) to include instrumentation scope attributes.
  • Change the instrumentation scope type definition from (Name,Version) tuple of strings to Instrumentation Scope definition (as the current definition misses Scheme URL and Attributes).
  • Refer to InstrumentationScope Data Model field in Bridge API to make the spec easier to follow.
  • Move the part relevant to Bridge API usage from the Data Model.
  • Remove "Version is optional. Name SHOULD be specified if version is specified, otherwise Name is optional." which should act as recommendation in the API. But the API already contains information how the parameters should be used.

pellared avatar Jan 31 '24 12:01 pellared

@tigrannajaryan PTAL. I addressed your comment.

pellared avatar Mar 12 '24 09:03 pellared