opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Clarify attributes parameter type of Get a Logger operation

Open pellared opened this issue 1 year ago • 0 comments

From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/bridge-api.md#get-a-logger:

  • attributes (optional): Specifies the instrumentation scope attributes to associate with emitted telemetry. This API MUST be structured to accept a variable number of attributes, including none.
  1. Attributes of what type are these? Log attributes or common attributes? My guess is that these are "common attributes" but should be clearly defined by the specification.

  2. What the implementation should with the provided attributes? Shouldn't the data model for instrumentation scope be updated to also contain the attributes? See OTLP defintion and glossary definition. I think it is a bug in the specification.

Related PR: https://github.com/open-telemetry/opentelemetry-go/pull/4809

pellared avatar Jan 24 '24 13:01 pellared