opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Stabilize "attributes" instrument advisory parameter

Open trask opened this issue 6 months ago • 5 comments

What are you trying to achieve?

Stability of Instrument advisory parameter: Attributes

Additional context.

Java Instrumentation is relying heavily on this feature, e.g. emitting HTTP span attributes on HTTP metrics and using this instrument advice to report only the expected attributes, and we would benefit from the feature being stable.

Has anyone else implemented/prototyped this advisory parameter yet?

cc @open-telemetry/go-approvers @open-telemetry/dotnet-approvers @open-telemetry/python-approvers @open-telemetry/javascript-approvers

trask avatar Dec 07 '23 01:12 trask

Current status: waiting for additional implementations to collect feedback.

Known implementations:

  • Java

@open-telemetry/go-approvers @open-telemetry/dotnet-approvers @open-telemetry/python-approvers @open-telemetry/javascript-approvers Can you please comment on whether or not this is implemented in your respective language?

jack-berg avatar Dec 13 '23 15:12 jack-berg

OTel .NET has not implemented this. I just created an issue to track this : https://github.com/open-telemetry/opentelemetry-dotnet/issues/5165

(Given .NET's special arrangement of maintaining the Metrics API in the .NET Runtime itself, the earliest we can do this is with next .NET release, which will be Nov 2024, with preview releases comings much earlier)

cijothomas avatar Dec 13 '23 18:12 cijothomas

We currently do not have a prototype for this in the JavaScript SIG. Edit: I also just created an issue to track this: https://github.com/open-telemetry/opentelemetry-js/issues/4365

pichlermarc avatar Dec 13 '23 18:12 pichlermarc

Linking related: #3790

trask avatar Dec 14 '23 16:12 trask

pre-requisite for Go: #3803

trask avatar Feb 09 '24 19:02 trask