opentelemetry-specification
opentelemetry-specification copied to clipboard
Clarify per-message attributes usage in batching scenarios
Messaging instrumentation SIG is working on spec changes and this change is one of the first steps to bring the consensus we reached in SIG to the spec.
This change clarifies that per-message attributes should be set on links when the corresponding span represents a batching operation. It introduced breaking changes (attribute renames)
messaging.message_idtomessaging.message.idmessaging.conversation_idtomessaging.message.conversation_idmessaging.message_payload_size_bytestomessaging.message.payload_size_bytesmessaging.message_payload_compressed_size_bytestomessaging.message.payload_compressed_size_bytes.
Going forward, we'd like to reserve messaging.message. namespace for other possible per-message attributes.
It also adds the messaging.batch_size attribute which intends to:
- denote a bathing operation
- record number of messages sent/received/processed - since links can be dropped or there can be some other links not describing messages, link count is not a reliable indicator of batch size. Assuming a high-scale scenario, users might want to opt-out from per-message tracing, but then batch_size would still be useful
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Not stale
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Not stale
Also, I support moving this PR out of draft and asking for reviews from the community so we can progress towards merging this.
Thanks everyone for the review! Per discussion at the last SIG meeting, I'm going to close this one and open a new PR - #2957 (to simplify final review process).