opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Metric names in specification don't match hostmetrics's paging scraper

Open crobert-1 opened this issue 2 years ago • 3 comments

Metric names should be consistent between specification and receiver scrapers. The metrics in question are from the hostmetrics receiver, specifically the paging scraper: system.paging.operations.page_in and system.paging.operations.page_out. The specification incorrectly labels these as system.paging.operations.in and system.paging.operations.out. I believe the README and code are correct and the specification needs to be updated to match, but I'm open to correction here.

The mismatch appeared as a part of the direction attribute removal for the paging scraper.

Specification hostmetrics receiver paging scraper README Relevant code showing page_in and page_out

crobert-1 avatar Aug 15 '22 21:08 crobert-1

Thank you for reporting this. Would you be willing to follow-up?

rbailey7210 avatar Aug 19 '22 15:08 rbailey7210

I'm unsure how to proceed based on #2726. It looks like discussion is going on to may revert these changes and revisit the metric format change. Reverting the changed would resolve this issue.

I think it may be best to wait and see what happens with the metric format change as a whole before fixing.

crobert-1 avatar Aug 19 '22 17:08 crobert-1

Yes, it looks like we will revert all changes stemming from the change of "direction", which I think means reverting the name change here.

jmacd avatar Aug 19 '22 17:08 jmacd