opentelemetry-specification icon indicating copy to clipboard operation
opentelemetry-specification copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

add user agent to OTLP exporter spec

Open codeboten opened this issue 2 years ago • 3 comments

Changes

The following PR adds a section to the OTLP exporter about setting a user agent. This was implemented in the otel collector and provides users with additional information to troubleshoot their telemetry pipelines with. This was discussed in the context of #2501. It's worth noting that the OpenTelemetry collector is currently setting a user agent in the format:

OpenTelemetry Collector Contrib/0.53.0 (linux/amd64) grpc-go/1.47.0

Additionally, existing exporters are already sending this header (using whatever the underlying library is setting), it's just not set to anything OpenTelemetry specific.

Related issues #2501

codeboten avatar Jul 21 '22 19:07 codeboten

Overall good, but we need more eyes on this.

@open-telemetry/specs-approvers please take a look.

carlosalberto avatar Aug 08 '22 13:08 carlosalberto

I would make this an "option" maybe opt-out.

bogdandrutu avatar Aug 09 '22 15:08 bogdandrutu

I would make this an "option" maybe opt-out.

@bogdandrutu today most (i believe at least all grpc and many http) OTLP exporters already have a user agent header, something like grpc-go/1.47.0, and there is no way to opt out. This PR is suggesting that the exporters should provide something more meaningful.

codeboten avatar Aug 09 '22 15:08 codeboten

@bogdandrutu Any further opinion on this?

carlosalberto avatar Aug 18 '22 15:08 carlosalberto

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Sep 06 '22 04:09 github-actions[bot]