opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

Deprecating opentelemetry-jaeger

Open cijothomas opened this issue 1 year ago • 10 comments

The current project for OpenTelemetry jaeger (https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-jaeger) seems to be doing 2 things:

  1. Jaeger propagator
  2. Jaeger exporter.

Proposing to do:

  1. Given the Jaeger exporter is slated to be deprecated (https://github.com/open-telemetry/opentelemetry-specification/pull/2858), proposing to remove the Jaeger exporter from this, and instead advice users to move to OTLP.

  2. The spec recommends Jaeger propagator to be shipped as an extension package (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#propagators-distribution). Once the exporter is removed, this package/crate can be renamed to reflect its actual purpose, which would be just the propagator. (a name change might also be needed)

cijothomas avatar Mar 13 '23 19:03 cijothomas

Some context here: Jaeger and OTLP create are two most popular creates we have. I think we can mark jaeger exporter as deprecated going forward but may need to give users sometime to switch to OTLP. We also need some documents and examples around how to swich.

TommyCpp avatar Mar 13 '23 20:03 TommyCpp

We also need some documents and examples around how to switch.

Adding a PR showing that for reference, if needed in this SIG : https://github.com/open-telemetry/opentelemetry-dotnet/pull/3940/files It also shows it was very straightforward to make the switch.

cijothomas avatar Mar 13 '23 22:03 cijothomas

The actix examples still use the jeager exporter, so there are no example showing how to use the recommended otlp exporters with actix or hyper.

DontBreakAlex avatar Apr 11 '23 15:04 DontBreakAlex

The actix examples still use the jeager, so there are no example showing how to use the recommended otlp exporters with actix or hyper.

Yes. This was discussed in today's SIG meeting. I'll be sending PR to update example to use OTLP Exporter for Jaeger.

cijothomas avatar Apr 11 '23 16:04 cijothomas

https://github.com/open-telemetry/opentelemetry-specification/pull/3567/files Spec has removed Jaeger exporter specs. Most other languages have removed. I'll start the clean up in this repo.

cijothomas avatar Oct 03 '23 03:10 cijothomas

Tagging with help-wanted if anyone willing to contribute!

cijothomas avatar Oct 19 '23 16:10 cijothomas

The next step would be to create a separate crate for the propagator alone, "opentelemetry-propagator-jaeger", extracting the propagation part from opentelemetry-jaeger crate.

cijothomas avatar Dec 12 '23 01:12 cijothomas

@cijothomas I'd be interested in taking on this work

mattbodd avatar Jan 19 '24 21:01 mattbodd

@cijothomas I'd be interested in taking on this work

Thanks! https://github.com/open-telemetry/opentelemetry-rust/issues/995#issuecomment-1851173398 lists the next step to be followed, and after that, we can work towards deprecating the current one. Feel free to explore/share any alternate ways of handling the deprecation in a smooth way!

cijothomas avatar Jan 19 '24 21:01 cijothomas

Commit has been merged to prepare release 0.21.0 as the first deprecated release. Notice prominent on the README and deprecation marker has been placed on objects to give users notice.

Currently 0.22.0 will be the last release.

I think depending on the feedback we get from users this may change. Something brought up by @TommyCpp is that we don't currently have testing for WASM on OTLP, and we can't know exactly why people are using the jaeger exporter yet.

hdost avatar Feb 19 '24 02:02 hdost