opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

Prepare for v0.18.0 release

Open jtescher opened this issue 2 years ago • 12 comments

See VERSIONING.md for what is being stabilized.

jtescher avatar Apr 10 '22 18:04 jtescher

Codecov Report

Base: 66.6% // Head: 66.6% // No change to project coverage :thumbsup:

Coverage data is based on head (09cab12) compared to base (6c1e487). Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #779   +/-   ##
=====================================
  Coverage   66.6%   66.6%           
=====================================
  Files        113     113           
  Lines       8783    8783           
=====================================
  Hits        5850    5850           
  Misses      2933    2933           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 10 '22 19:04 codecov[bot]

Hm, not sure if this is a good idea. The way Cargo version resolution, it considers pre-releases semver-compatible with other pre-releases for the same release. Thus, if you release this and there would later be a 1.0.0-beta.2 with any semver-incompatible changes in it, you would break all downstream users.

djc avatar Apr 11 '22 08:04 djc

@djc good point, is there a better beta convention?

jtescher avatar Apr 11 '22 16:04 jtescher

Hmm, can't think of anything that's widely used in the Rust ecosystem. What is the point of calling it beta? I'd probably just bump the minor version and communicate the status against the spec in the release notes.

djc avatar Apr 11 '22 16:04 djc

+1 on release using 0.x version and adding notes to communicate this is a beta 1.0 release. Also, I don't think the VERSIONING.md is clear about what we are stabilizing(should only be the trace feature). Maybe need to add that to the release note?

TommyCpp avatar Apr 12 '22 02:04 TommyCpp

Do we want to wait for #781 as it has an API change?

TommyCpp avatar Apr 21 '22 02:04 TommyCpp

Do we want to wait for #781 as it has an API change?

I think that would make sense.

djc avatar Apr 21 '22 08:04 djc

Any chance this will land soon? We are eagerly awaiting the new version. :smile:

jwilm avatar Jun 23 '22 18:06 jwilm

Should be soon hopefully, just have to resolve the MSRV issues on main

jtescher avatar Jun 24 '22 19:06 jtescher

@open-telemetry/rust-approvers should we wait for the current open PRs to land? or merge this sooner than that.

jtescher avatar Jul 09 '22 23:07 jtescher

I think we should include #833 as it includes a fairly important fix for sampling IMO

TommyCpp avatar Jul 09 '22 23:07 TommyCpp

I'll make sure to get that finished , theres also a change in the samplers which I can adjust there as well.

hdost avatar Jul 12 '22 07:07 hdost

@djc need a 👍 to merge 😄

jtescher avatar Sep 11 '22 23:09 jtescher