opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

Support all configuration of otlp exporter

Open TommyCpp opened this issue 2 years ago • 5 comments

Add support for all configurations in spec

  • [ ] Endpoint (OTLP/HTTP) - It was partially supported with #773 missing
  • [x] Endpoint (OTLP/gRPC)
  • [ ] Insecure
  • [ ] Certificate File
  • [ ] Client key file
  • [ ] Client certificate file
  • [ ] Headers
  • [ ] Compression
  • [ ] Timeout
  • [ ] Protocol

TommyCpp avatar Apr 06 '22 06:04 TommyCpp

Does opentelemtry-otlp already add the signal path automatically when using gRPC?

TylerHelmuth avatar May 17 '22 14:05 TylerHelmuth

Does opentelemtry-otlp already add the signal path automatically when using gRPC?

gRPC doesn't really require a path, right? The service/client stub should take care of that

TommyCpp avatar May 18 '22 03:05 TommyCpp

You're totally right, my bad

TylerHelmuth avatar May 18 '22 04:05 TylerHelmuth

Hey all! I'm interested in trying to implement one of the items in the list as a way to get more familiar with the repository. Certificate file looks like a good candidate. However, I am struggling with seeing the configuration flow in general. Could you please share some pointers on how to go about implementing it?

For example, I am testing locally with tonic. I managed to connect over TLS to a collector using new_exporter().tonic().with_tls_config(ClientTlsConfig::new(...)). However, this is tonic-specific. Based on the linked spec above, I assume the new way of configuring should be taken into account within all protocols (i.e different third party crates). Is that correct?

If that is the case, the ExportConfig struct looks like a good place to add it. Then, though, ExportConfig and TonicConfig.tls_config may have different values and one needs to take precedence over the other. How/where would that be decided?

I do hope any of that makes sense. Thanks!

atanunq avatar Jun 09 '22 23:06 atanunq

Related https://github.com/open-telemetry/opentelemetry-rust/issues/984

hdost avatar Feb 21 '24 09:02 hdost