opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

Remove global shutdown from metrics and doc fixes

Open cijothomas opened this issue 9 months ago • 2 comments

Fixes https://github.com/open-telemetry/opentelemetry-rust/issues/1679

cijothomas avatar May 11 '24 21:05 cijothomas

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.6%. Comparing base (348ec9e) to head (fe4dd4c). Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1743     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20829     +78     
=======================================
+ Hits       14746   14924    +178     
+ Misses      6005    5905    -100     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 11 '24 21:05 codecov[bot]

Just to summarise my understanding of the existing behavior after this PR:

  • The global shutdown is now removed for metrics and logs. And shutdown will happen when
    • explicitly invoked from any of the Sdk*Provider's, Or
    • All the references to the providers are dropped.
  • From traces, global shutdown will drop the global provider, and invoke shutdown (through drop) if there are no other provider references.

lalitb avatar May 11 '24 22:05 lalitb