opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

Revisit shutdown_signal_provider methods at API level

Open lalitb opened this issue 10 months ago • 3 comments

          I think we need to revisit `shutdown_*_provider` methods as they are at the API level. The instrumented libraries shouldn't have the method to shutdown the LoggerProvider enabled by the application.

Originally posted by @lalitb in https://github.com/open-telemetry/opentelemetry-rust/pull/1643#discussion_r1576473716

lalitb avatar Apr 23 '24 17:04 lalitb

https://github.com/open-telemetry/opentelemetry-rust/pull/1643#discussion_r1579840322 We may be able to this entirely at API level, for the logging signal. (still need it/similar capability for metrics,traces)

cijothomas avatar Apr 25 '24 17:04 cijothomas

We may be able to this entirely at API level

To clearify you mean remove shutdown, get logger, get logger provider, set logger provider entirely for logging signal?

TommyCpp avatar Apr 25 '24 18:04 TommyCpp

For v0.23 release: This is not an issue for logs, as logs removed the global shutdown completely. Not an issue for traces, as global shutdown existed even before this release. For metrics, this is newly introduced in v0.23. An example on how to shutdown even without the global_shutdown : https://github.com/open-telemetry/opentelemetry-rust/pull/1739

cijothomas avatar May 11 '24 17:05 cijothomas