opentelemetry-rust
opentelemetry-rust copied to clipboard
[WIP] Try using a builder pattern for all signal providers
Fixes #1527 Design discussion issue (if applicable) #1527
Changes
This is currently just an exploratory PR to aid in the design discussion of the attached issue. May upgrade this PR and submit for review depending on the discussion result.
Merge requirement checklist
- [ ] CONTRIBUTING guidelines followed
- [ ] Unit tests added/updated (if applicable)
- [ ] Appropriate
CHANGELOG.md
files updated for non-trivial, user-facing changes - [ ] Changes in public API reviewed (if applicable)
@izquierdo Do you want us to review now, or should we wait till PR is marked non-draft?
@izquierdo Do you want us to review now, or should we wait till PR is marked non-draft?
Please wait until the PR is marked as non-draft.
However, I made a comment here: https://github.com/open-telemetry/opentelemetry-rust/issues/1527#issuecomment-1969954371
Codecov Report
Attention: Patch coverage is 76.56904%
with 56 lines
in your changes are missing coverage. Please review.
Project coverage is 69.0%. Comparing base (
f203b03
) to head (6498a95
). Report is 9 commits behind head on main.
:exclamation: Current head 6498a95 differs from pull request most recent head 68ce4bc. Consider uploading reports for the commit 68ce4bc to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #1567 +/- ##
=======================================
- Coverage 69.3% 69.0% -0.3%
=======================================
Files 136 136
Lines 19637 19587 -50
=======================================
- Hits 13610 13525 -85
- Misses 6027 6062 +35
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Let me open this for review as is, with loggers and tracers. Will leave metrics out of this PR.
Will you help with replicating this for Meter as well?
Yes! But in a separate PR