opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Remove aws id generator from core sdk

Open cijothomas opened this issue 1 year ago • 3 comments

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/trace/id_generator/aws.rs must be moved to contrib crate and should not be part of core sdk.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#id-generators

cijothomas avatar Jan 24 '24 15:01 cijothomas

how do we proceed with the removal from the core repo? Do we add a deprecated message/warning and release a version?

sreeo avatar Feb 20 '24 18:02 sreeo

https://github.com/open-telemetry/opentelemetry-rust/pull/1560 You can copy some of the ideas from this PR. (That PR removes an entire crate, but this is just a functionality, so adjust wordings accordingly.)

cijothomas avatar Feb 20 '24 18:02 cijothomas

Would this be the right time to raise a PR where the XrayIdGenerator is removed from the core repo? Or do we wait for a few releases?

sreeo avatar Mar 18 '24 04:03 sreeo

Would this be the right time to raise a PR where the XrayIdGenerator is removed from the core repo? Or do we wait for a few releases?

Hey sorry I missed this message until now! It should be removed now : https://github.com/open-telemetry/opentelemetry-rust/pull/1820

cijothomas avatar May 24 '24 06:05 cijothomas