opentelemetry-rust
opentelemetry-rust copied to clipboard
Fix aggregation bug due to stale hash value
Fixes #1418 Accidental side effect of this PR: https://github.com/open-telemetry/opentelemetry-rust/pull/1407
Changes
Re-calculates hash, if attributes are changed, which can occur when View is configured to drop attributes. Not adding changelog, as this can be part of the #1407 itself, and we haven't released with that yet.
Merge requirement checklist
- [ ] CONTRIBUTING guidelines followed
- [ ] Unit tests added/updated (if applicable)
- [ ] Appropriate
CHANGELOG.mdfiles updated for non-trivial, user-facing changes - [ ] Changes in public API reviewed (if applicable)
Maybe better to fold this into https://github.com/open-telemetry/opentelemetry-rust/pull/1421
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.8%. Comparing base (
35c7803) to head (eda0001). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1422 +/- ##
=======================================
+ Coverage 67.3% 67.8% +0.4%
=======================================
Files 138 139 +1
Lines 19654 19687 +33
=======================================
+ Hits 13243 13363 +120
+ Misses 6411 6324 -87
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Maybe better to fold this into #1421
This needs to proceed as-is now, as 1421 is reverted.