opentelemetry-rust icon indicating copy to clipboard operation
opentelemetry-rust copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

SpanContext should implement serde::Serialize, Deserialize

Open shaun-cox opened this issue 1 year ago • 2 comments

Per Rust API Guidelines for Interoperability I think SpanContext should implement serde::Serialize and Deserialize.

I'll see about making this contribution myself, but wanted to open the issue in case there is disagreement with the approach. (From my understanding, we want to prefer idiomatic usage of the language features for the API.) This will help me and others in building domain-specific propagators ala .with_remote_span_context.

shaun-cox avatar May 23 '23 19:05 shaun-cox

Closing this in favor of discussion on #1075.

djc avatar May 24 '23 07:05 djc

Sorry, I missed that #1075 is the PR for fixing this.

djc avatar May 24 '23 08:05 djc