opentelemetry-ruby icon indicating copy to clipboard operation
opentelemetry-ruby copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

feat: Add Elasticsearch instrumentation

Open mmontalvo opened this issue 3 years ago • 8 comments

Linked to open-telemetry/opentelemetry-ruby-contrib#8

mmontalvo avatar Apr 07 '21 00:04 mmontalvo

CLA Signed

The committers are authorized under a signed CLA.

  • :white_check_mark: Miguel Montalvo (d82b9c9fb51467c46abd9a6af10060028d08c912)

linux-foundation-easycla[bot] avatar Apr 07 '21 00:04 linux-foundation-easycla[bot]

I also failed to welcome you @mmontalvo ! Thanks for helping get this instrumentation implemented!!!

arielvalentin avatar May 14 '21 01:05 arielvalentin

I also failed to welcome you @mmontalvo ! Thanks for helping get this instrumentation implemented!!!

Thanks @arielvalentin! And also thanks for your review! 👍

mmontalvo avatar May 14 '21 01:05 mmontalvo

Sorry for the delay, definitely will update it this week

mmontalvo avatar Jun 09 '21 08:06 mmontalvo

Looking forward to this!

johnnyshields avatar Aug 25 '21 09:08 johnnyshields

@mmontalvo any time to update this?

johnnyshields avatar Dec 13 '21 11:12 johnnyshields

Anyone else in the community want to take this effort over? It would be great to have this.

johnnyshields avatar Feb 05 '22 02:02 johnnyshields

Hello, and thank you for your contribution!

We recently split Ruby instrumentation out into the opentelemetry-ruby-contrib repo.

This PR is related to instrumentation, so we'll need you to re-open it against opentelemetry-ruby-contrib. Sorry for the inconvenience!

To do that, you can:

  1. Create a fork of opentelemetry-ruby-contrib and copy the git url
  2. In your opentelemetry-ruby repo, run git remote add tmp-contrib <your-fork-git-url>
  3. git push tmp-contrib your-branch-name
  4. Open a new PR in contrib (feel free to just copy/paste your original PR description there)
  5. Close your open PR in this repo with a comment that links to your new PR in contrib
  6. Delete your tmp-contrib remote from opentelemetry-ruby (git remote rm tmp-contrib)
  7. git clone your opentelemetry-ruby-contrib fork, check out your branch, and make all changes in that repo from now on!

Sorry again for the inconvenience, and thank you for contributing!

plantfansam avatar Jun 17 '22 17:06 plantfansam

👋 Hi, @mmontalvo! Thank you for your PR!

As Sam mentioned, Ruby instrumentation now lives in the opentelemetry-ruby-contrib repo. We'd be happy to take another look at your work in that context.

Since it cannot be merged here, I'm going to close this PR.

Thank you for your contribution. We hope to work with you again soon!

kaylareopelle avatar Apr 01 '24 21:04 kaylareopelle