opentelemetry-ruby icon indicating copy to clipboard operation
opentelemetry-ruby copied to clipboard

Docs for Jaeger collector exporter are wrong

Open genebean opened this issue 5 years ago • 7 comments

The docs at https://github.com/open-telemetry/opentelemetry-ruby/tree/master/exporter/jaeger don't include the /api/traces path that is required via https://github.com/open-telemetry/opentelemetry-ruby/blob/ed28a6bc2a7ce7cfcad9c2940c596a651d9a6782/exporter/jaeger/lib/opentelemetry/exporter/jaeger/collector_exporter.rb#L18

Either the docs are wrong or the initial setting of the endpoint needs updating to append that path automatically.

genebean avatar Sep 11 '20 19:09 genebean

i think a few exporter docs have issues at the moment actually , otlp collector exporter has a code example using incorrect args i believe https://github.com/open-telemetry/opentelemetry-ruby/tree/master/exporter/otlp#how-do-i-get-started

Maybe we should group these all as one chunk of cleanup work

ericmustin avatar Sep 15 '20 14:09 ericmustin

#427 will take care of the original issue listed here but does not address the otlp exporter docs.

genebean avatar Oct 04 '20 18:10 genebean

Will be happy to help with that :)

rydzykje avatar Nov 14 '20 21:11 rydzykje

Thanks @rydzykje - I've assigned this to you.

fbogsany avatar Nov 16 '20 20:11 fbogsany

@rydzykje what's up

inductor avatar Sep 21 '21 14:09 inductor

opened #986 to fix the otlp exporter docs.

vsrnth avatar Oct 18 '21 05:10 vsrnth

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

github-actions[bot] avatar Apr 27 '24 01:04 github-actions[bot]