opentelemetry-ruby icon indicating copy to clipboard operation
opentelemetry-ruby copied to clipboard

Update MetricStream defaults

Open kaylareopelle opened this issue 1 year ago • 2 comments

Update the MetricStream class to more closely match the specification: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#stream-configuration

Originally from: https://github.com/open-telemetry/opentelemetry-ruby/pull/1604#discussion_r1683588187

kaylareopelle avatar Jul 24 '24 22:07 kaylareopelle

Hi @kaylareopelle,

While I was trying to resolve this spec issue, I came up with more questions.

Based on the spec, all the configuration options are optional (e.g., Users can provide a <>, but it is up to their discretion.). So, I was wondering if we should change the MetricStream class initialization to use dictionary-type parameters?

def initialize(
  name: name,
  description: description,
  unit: unit,
  instrument_kind: instrument_kind,
  meter_provider: meter_provider,
  instrumentation_scope: instrumentation_scope,
  aggregation: aggregation,
  ...
)

FYI, I think MetricStream is not supposed to be accessed or used by end-users because, currently, MetricStream is only used during the initialization of synchronous_instrument. I guess we don’t need to worry about adding new options (e.g., exemplar_reservoir) that might confuse end-users.

xuan-cao-swi avatar Aug 07 '24 20:08 xuan-cao-swi

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

github-actions[bot] avatar Sep 07 '24 01:09 github-actions[bot]