opentelemetry-ruby
opentelemetry-ruby copied to clipboard
Handle `-` in generated instrumentation name
Currently, dashes are ignored, resulting in invalid constants such as
OpenTelemetry::Instrumentation::Foo-bar::VERSION
being generated by running
bin/instrumentation_generator foo-bar
While convention would dictate that foo-bar
map to Foo::Bar
, this would require a larger refactor.
Hello, and thank you for your contribution!
We recently split Ruby instrumentation out into the opentelemetry-ruby-contrib
repo.
This PR is related to instrumentation, so we'll need you to re-open it against opentelemetry-ruby-contrib
. Sorry for the inconvenience!
To do that, you can:
-
Create a fork of
opentelemetry-ruby-contrib
and copy the git url - In your
opentelemetry-ruby
repo, rungit remote add tmp-contrib <your-fork-git-url>
-
git push tmp-contrib your-branch-name
- Open a new PR in contrib (feel free to just copy/paste your original PR description there)
- Close your open PR in this repo with a comment that links to your new PR in contrib
- Delete your
tmp-contrib
remote fromopentelemetry-ruby
(git remote rm tmp-contrib
) -
git clone
youropentelemetry-ruby-contrib
fork, check out your branch, and make all changes in that repo from now on!
Sorry again for the inconvenience, and thank you for contributing!
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep
label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot