opentelemetry-ruby
opentelemetry-ruby copied to clipboard
Use `spec.version` in `gemspec` instead of constant
Since we've already assigned
spec.version = OpenTelemetry::Instrumentation::<%= pascal_cased_instrumentation_name %>::VERSION
we can use spec.version
instead of interpolating the fully qualified constant, which makes things a little more readable.
Why bother?
I generated a new integration but it got the constant name slightly wrong. Because we use the constant name multiple times, I had to manually fix more occurrences than I would have had to with this change. 🤷
Hello, and thank you for your contribution!
We recently split Ruby instrumentation out into the opentelemetry-ruby-contrib
repo.
This PR is related to instrumentation, so we'll need you to re-open it against opentelemetry-ruby-contrib
. Sorry for the inconvenience!
To do that, you can:
-
Create a fork of
opentelemetry-ruby-contrib
and copy the git url - In your
opentelemetry-ruby
repo, rungit remote add tmp-contrib <your-fork-git-url>
-
git push tmp-contrib your-branch-name
- Open a new PR in contrib (feel free to just copy/paste your original PR description there)
- Close your open PR in this repo with a comment that links to your new PR in contrib
- Delete your
tmp-contrib
remote fromopentelemetry-ruby
(git remote rm tmp-contrib
) -
git clone
youropentelemetry-ruby-contrib
fork, check out your branch, and make all changes in that repo from now on!
Sorry again for the inconvenience, and thank you for contributing!
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep
label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot
👋 Hi, @sambostock! Thank you for your PR!
As Sam mentioned, Ruby instrumentation now lives in the opentelemetry-ruby-contrib repo. We'd be happy to take another look at your work in that context.
Since this PR is focused on instrumentation, I'm going to close it.
We appreciate your contribution and hope to work with you again soon!