opentelemetry-ruby
opentelemetry-ruby copied to clipboard
feat: add support for job_options argument
In Que v1.2, it was deprecated to pass top level keyword args in the
enqueue
method. This is to prepare for Que v2. This causes warnings
such as:
Passing job options like (tags) to `JobClass.enqueue` as top level keyword args has been deprecated and will be removed in version 2.0. Please wrap job options in an explicit `job_options` keyword arg instead.
The keyword arguments are: queue
, priority
, run_at
, tags
, and
job_class
. These must be wrapped around the job_options
keyword.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: bautrey37 / name: Brandon (a74bf38cd592e811540fc0db05714157b54678bb)
This is my first PR here. I believe this should be a minor version bump since the underlying gem que
is being upgraded. Upgrading que
to the latest v1, would require additional changes such as migrating the que database, so v1.2 is the acceptable minimum version for now.
Thanks so much for the contributions @bautrey37 and @indrekj! We're definitely on the right track here! It looks like some of the specs are failing, though. The test output can be a bit hard to read, but if you search for 7 failures
you should be able to track them down. Mind taking a look? Happy to assist with debugging 😄.
@plantfansam Can you assist me? I updated the branch, and now the build checks that were there, are no longer there. What happened to them?
@plantfansam Can you assist me? I updated the branch, and now the build checks that were there, are no longer there. What happened to them?
Kicked off a test run 🎉
@bautrey37 I think your tests are failing because you haven't updated the Appraisals file
Hello, and thank you for your contribution!
We recently split Ruby instrumentation out into the opentelemetry-ruby-contrib
repo.
This PR is related to instrumentation, so we'll need you to re-open it against opentelemetry-ruby-contrib
. Sorry for the inconvenience!
To do that, you can:
-
Create a fork of
opentelemetry-ruby-contrib
and copy the git url - In your
opentelemetry-ruby
repo, rungit remote add tmp-contrib <your-fork-git-url>
-
git push tmp-contrib your-branch-name
- Open a new PR in contrib (feel free to just copy/paste your original PR description there)
- Close your open PR in this repo with a comment that links to your new PR in contrib
- Delete your
tmp-contrib
remote fromopentelemetry-ruby
(git remote rm tmp-contrib
) -
git clone
youropentelemetry-ruby-contrib
fork, check out your branch, and make all changes in that repo from now on!
Sorry again for the inconvenience, and thank you for contributing!
@plantfansam Thank you for the help. I've opened up the PR on the contrib repo. Can you take a look? Thanks.