opentelemetry-ruby
opentelemetry-ruby copied to clipboard
update default max packetsize to 64k to prevent too big packets sent
Quick "Fix" proposal for bug https://github.com/open-telemetry/opentelemetry-ruby/issues/1148
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: thomasLeclaire / name: Thomas Leclaire (2e796eb3fcbafa488c5c0ce3b5f73773894ac747)
Thanks for the bug report @thomasLeclaire. I think the problem goes a little deeper than this, and I'd like us to fix the root cause. We are not only ignoring the Thrift protocol overhead, we are also ignoring the Process (Resource, in OTel terminology) size in the batching calculation. This is a lot more variable and I don't think we can just drop the limit by 1000 bytes.
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep
label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot