opentelemetry-ruby icon indicating copy to clipboard operation
opentelemetry-ruby copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

update default max packetsize to 64k to prevent too big packets sent

Open thomasLeclaire opened this issue 2 years ago • 2 comments

Quick "Fix" proposal for bug https://github.com/open-telemetry/opentelemetry-ruby/issues/1148

thomasLeclaire avatar Mar 16 '22 10:03 thomasLeclaire

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: thomasLeclaire / name: Thomas Leclaire (2e796eb3fcbafa488c5c0ce3b5f73773894ac747)

linux-foundation-easycla[bot] avatar Mar 16 '22 10:03 linux-foundation-easycla[bot]

Thanks for the bug report @thomasLeclaire. I think the problem goes a little deeper than this, and I'd like us to fix the root cause. We are not only ignoring the Thrift protocol overhead, we are also ignoring the Process (Resource, in OTel terminology) size in the batching calculation. This is a lot more variable and I don't think we can just drop the limit by 1000 bytes.

fbogsany avatar Mar 17 '22 15:03 fbogsany

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

github-actions[bot] avatar Mar 31 '24 01:03 github-actions[bot]